fix: enforce correct icaltype when constructing VCardTime - #4616
Conversation
Signed-off-by: Richard Steinmetz <richard@steinmetz.cloud>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4616 +/- ##
=========================================
Coverage 10.56% 10.56%
Complexity 265 265
=========================================
Files 123 123
Lines 5767 5767
Branches 1262 1262
=========================================
Hits 609 609
Misses 5035 5035
Partials 123 123 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Signed-off-by: SebastianKrupinski <krupinskis05@gmail.com>
GVodyanov
left a comment
GVodyanov
left a comment
There was a problem hiding this comment.
I can still reproduce the error by creating or updating a contact and I can't understand why, even after having run a clean install of dependencies.
Does this maybe only work if server is updated? Mine hasn't been updated for a while, is that a requirement for this to work?
|
Fixed in #4634 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
4 participants
Extracted from #4298
On my testing instance I don't see the "repaired invalid rev" error any longer.